Add DynamicAccessedMembers attributes to BindingListEx methods#1087
Add DynamicAccessedMembers attributes to BindingListEx methods#1087daniel-lerch wants to merge 2 commits into
Conversation
|
So, the failing test is the one that makes sure that any changes to the public API surface go through an extra step of verification. There's 2 text files under DynamicData.Tests/API that track the "verified" version of the API surface, which are what the test compares against to detect changes. If you're running on Windows, you should be able to run the API test in VS, and when it fails, it'll launch an instance of WinMerge that'll let you merge the changes it detects into the "verified" file. Otherwise, you'll have to diff the generated files against the verified files manually, and marge the changes in. |
|
Thanks for the hint @JakenVeina! My Visual Studio somehow did not want to run these tests but .NET CLI on Linux worked. |
|
I'm gonna hold off on merging this until we get #1088 worked out, so this can be our guinea pig for auto-publishing a preview release. |
2 participants
This pull request enables
IsAotCompatibleand fixes the few remaining warnings (resolves #1086). By enabling this flag, warning newly introduced in future .NET versions should become visible once new target frameworks are being added.Notes to reviewers:
net8.0target framework because Visual Studio 2026 did not allow me to build the project with duplicate target frameworks.DynamicallyAccessedMemberTypes.Allfor annotatingBindingListExwhich is not exactly the same asTypeDescriptor.AllMembersAndInterfaceswhich is being used byBindingList<T>internally. However, that special value is internal and verbose to replicate in a way compatible with various .NET versions.